Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add an encoding roundtrip for Struct #559

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

tests: add an encoding roundtrip for Struct #559

wants to merge 2 commits into from

Conversation

woodruffw
Copy link
Contributor

Summary

Follows #551. This currently fails, as expected, since dump() is not correctly specialized for Struct.

This is a work in progress.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@woodruffw woodruffw mentioned this pull request Feb 25, 2024
Merged
7 tasks
@woodruffw
Copy link
Contributor Author

Just to post a brief update: per #551 (comment) and below, I don't yet have a great idea for a patch here. The basic thing that needs to happen is that dump() and load() need to be specialized for Struct, but doing so is weird because Struct is not referentially transparent against the underlying map<string, ...> type it contains.

@woodruffw woodruffw mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woodruffw